added bfs and operator<< methods #58
Conversation
include/GraphMatrix.hpp
Outdated
| } | ||
| } | ||
|
|
||
| friend std::ostream& operator<<(std::ostream& src, const GraphMatrix& other) { |
There was a problem hiding this comment.
Why is there a << operator in the class?
There was a problem hiding this comment.
Mostly for convenience. It allows for printing basic information about the graph using
std::cout << graph
There was a problem hiding this comment.
Thats a good approach.
But actually its not needed, the << operator overload is reserved for future to read graphs from a file, also user can print the graphs according to how they want, printing graphs on the console is not the concern of the library. 👍🏼
Update local repository with updated branch
include/GraphMatrix.hpp
Outdated
| } | ||
| } | ||
|
|
||
| std::vector<EdgeType> bfs(size_t start, size_t maxDepth) { |
There was a problem hiding this comment.
Shouldn't the start variable be of type VertexType? because user is passing in a vertex to start bfs from?
| std::vector<EdgeType> bfs(size_t start, size_t maxDepth) { | |
| std::vector<EdgeType> bfs(VertexType start, size_t maxDepth) { |
There was a problem hiding this comment.
Yeah, you're rights. I can make that change
SharonIV0x86
added
feature addition
|
Your current implementation will not work with custom vertex and edge types. There is a reason that as of now the library doesn't have its While i appreciate taking your interest in contributing to Appledore, the algorithms implementation such as dfs and bfs will require much time and testing to be implmented. If you'd like you can work on the following open issues, or if you'd like to continue working with your
|
|
Ok, I will work on writing some tests and making the implementation work independent of type. Any feedback from time to time is much appreciated |
|
SharonIV0x86
added
wontfix
2 participants
Additions: